Open
Conversation
|
DeputyDev will no longer review pull requests automatically.To request a review, simply comment #review on your pull request—this will trigger an on-demand review whenever you need it. |
| "@babel/plugin-transform-runtime", | ||
| { | ||
| helpers: true, | ||
| regenerator: true, |
Collaborator
There was a problem hiding this comment.
why did we need this?
| test: /[\\/]node_modules[\\/](react|react-dom|react-redux|react-router|react-router-dom|redux|redux-thunk|axios|react-loadable-visibility|react-helmet-async|react-fast-compare|react-async-script|@babel\/runtime|@loadable\/component|catalyst)[\\/]/, | ||
| name: "commonVendor", | ||
| minSize: 30000, | ||
| priority: 10, |
Collaborator
There was a problem hiding this comment.
why have we added priority here
| }, | ||
| module: { | ||
| rules: [ | ||
| { |
Collaborator
There was a problem hiding this comment.
the rules for js files are already defined in base.babel
| chunkFilename: catalystConfig.chunkFileNameProd, | ||
| filename: "handler.js", | ||
| libraryTarget: "commonjs", | ||
| publicPath: path.join(process.env.src_path, process.env.BUILD_OUTPUT_PATH, "/renderer") + "/", |
Collaborator
There was a problem hiding this comment.
why do you need this. Already defined in base babel
ankitakataria1mg
force-pushed
the
feat/react-version-upgrade
branch
from
3b50db0 to
aaca95c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.