Add deps required to build other deps#232
Open
cmcaine wants to merge 1 commit intotaspinar:masterfrom
Open
Conversation
This increases the size of the image quite a lot.
Owner
|
Same here, |
Author
|
Probably not, if people are reporting success with 253. My comment about pinning the alpine version is still relevant, tho. An alternative would be testing the dockerfile with CI, but that sounds like a lot of wasted cycles to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This increases the size of the image quite a lot.
Alternatives welcomed. Would also be nice to pin the container version so that this doesn't become stale again, but I don't know if you want to do that.
We can pin by setting FROM to python:3.7-alpine3.10.