refactor: rename delay label to x_delay to avoid conflict SmartRetryMiddleware#54
Open
MikhailWar wants to merge 1 commit into
Open
Conversation
s3rius
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix label collision between broker and SmartRetryMiddleware
Problem
When configuring a retry delay on a specific task, the task is never retried:
The delay=15 label gets embedded into every message for that task. AioPikaBroker reads the same delay
label and tries to route the message through a delay queue. Since no delay_queue or
delayed_message_exchange_plugin is configured, the broker raises:
Using SmartRetryMiddleware(default_delay=5) works fine because the default is handled by the middleware
itself and not stored as a task label.
Fix
Rename the broker's label from delay to x_delay. The x_ prefix follows the RabbitMQ convention for custom
headers and makes it clear this label belongs to the transport layer, not to retry logic.
Migration