tests: fix flaky TestGracefulShutdown #510
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
requested changes
Dec 7, 2025
Collaborator
There was a problem hiding this comment.
Thank you for the patch. But I don't get the idea clearly.
Why could not we just replace the exec.Command(getTarantoolExec(), "--version").Output() with exec.Command(getTarantoolExec(), "--version").CombinedOutput(). Is there any reason for left the first call?
go-tarantool/test_helpers/main.go
Line 238 in 74f82da
test_helpers/main.go
Outdated
| } | ||
|
|
||
| // It seems that is the --version output sometimes goes to Stderr instead of Stdout. | ||
| if string(out) == "" { |
Collaborator
There was a problem hiding this comment.
This is a simpler comparison from a reader point of view.
Suggested change
| if string(out) == "" { | |
| if len(out) == 0 { |
laines-it
force-pushed
the
laines-it/gh-503-flaky-TestGracefulShutdown
branch
2 times, most recently
from
7030d30 to
3972e75
Compare
laines-it
force-pushed
the
laines-it/gh-503-flaky-TestGracefulShutdown
branch
from
3972e75 to
88631d2
Compare
It seems that is the --version output sometimes goes to Stderr instead of Stdout. In IsTarantoolVersionLess() added CombinedOutput (stdout+stderr), if exec.Cmd.Output() returned empty string while executing `tarantool --version`. Closes #503
laines-it
force-pushed
the
laines-it/gh-503-flaky-TestGracefulShutdown
branch
from
88631d2 to
05db27f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that is the --version output
sometimes goes to Stderr instead of Stdout.
In IsTarantoolVersionLess() added CombinedOutput (stdout+stderr),
if exec.Cmd.Output() returned ""
while executing
tarantool --version.Closes #503