lint: enabled errcheck #506
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
requested changes
Dec 1, 2025
Collaborator
oleg-jukovec
left a comment
oleg-jukovec
left a comment
There was a problem hiding this comment.
Let's not just ignore errors everywhere, but handle the error if it appropriate.
ermyar
force-pushed
the
ermyar/gh-334-enabling-linter-errcheck
branch
from
a423cbc to
8a2d56f
Compare
oleg-jukovec
requested changes
Dec 5, 2025
Collaborator
oleg-jukovec
left a comment
oleg-jukovec
left a comment
There was a problem hiding this comment.
Thank you, a couple more comments.
CHANGELOG.md
Outdated
|
|
||
| * New types for MessagePack extensions compatible with go-option (#459). | ||
| * Added `box.MustNew` wrapper for `box.New` without an error (#448). | ||
| * Enabled `errcheck` in linter. |
Collaborator
There was a problem hiding this comment.
It is something about an internal implementation so we don't the changelog entry.
deadline_io.go
Outdated
Comment on lines
15
to
23
| _ = d.c.SetWriteDeadline(time.Now().Add(d.to)) | ||
| } | ||
| n, err = d.c.Write(b) | ||
| return | ||
| } | ||
|
|
||
| func (d *deadlineIO) Read(b []byte) (n int, err error) { | ||
| if d.to > 0 { | ||
| d.c.SetReadDeadline(time.Now().Add(d.to)) | ||
| _ = d.c.SetReadDeadline(time.Now().Add(d.to)) |
Collaborator
There was a problem hiding this comment.
It would be nice to check the return value here too.
decimal/decimal_test.go
Outdated
| b.ResetTimer() | ||
| for n := 0; n < b.N; n++ { | ||
| EncodeStringToBCD(testcase.numString) | ||
| _, _ = EncodeStringToBCD(testcase.numString) |
Collaborator
There was a problem hiding this comment.
It would be nice to have asserts of error == nil here too.
decimal/decimal_test.go
Outdated
| b.ResetTimer() | ||
| for n := 0; n < b.N; n++ { | ||
| DecodeStringFromBCD(bcdBuf) | ||
| _, _, _ = DecodeStringFromBCD(bcdBuf) |
Collaborator
There was a problem hiding this comment.
It would be nice to have asserts of error == nil here too.
Collaborator
|
Please, change the link to the issue:
|
Tests and methods are updated with enabling `errcheck` for `golangci-lint` check. Closes #334
ermyar
force-pushed
the
ermyar/gh-334-enabling-linter-errcheck
branch
from
8a2d56f to
5959070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests and methods are updated with enabling
errcheckforgolangci-lintcheck.Closes #334
I didn't forget about (remove if it is not applicable):