fix(constraint): call constraint for map and array types#6
Merged
Conversation
In the old validator (bench/validator.lua:897) constraint was called for all types from a single shared code path. In the C implementation it was only wired up in cv_check_scalar, leaving map and array silently ignoring the constraint field. Add constraint invocation in cv_check_map (step 3, before transform) and cv_check_array (before transform), matching the original behaviour: called only on success, value in details is the pre-transform value. Add regression tests in test/compat_test.lua: test_map_constraint and test_array_constraint.
ImeevMA
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the old validator (bench/validator.lua:897) constraint was called for all types from a single shared code path. In the C implementation it was only wired up in
cv_check_scalar, leaving map and array silently ignoring the constraint field.
Add constraint invocation in cv_check_map (step 3, before transform) and cv_check_array (before transform), matching the original behaviour: called only on success, value in details is the pre-transform value.
Add regression tests in test/compat_test.lua:
test_map_constraint and test_array_constraint.