fix(default): deepcopy table defaults on each check() call#4
Merged
Conversation
Default table values were stored as a single Lua registry reference and reused by reference on every check() call. Mutating the returned value would corrupt subsequent calls. Fix both application sites: - top-level default in cv_schema_check - field-level default in cv_check_map Field-level default now also runs cv_check_node on the copied value, so nested defaults are applied recursively. Add regression test in test/inplace_default_deepcopy_test.lua.
ImeevMA
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default table values were stored as a single Lua registry reference and reused by reference on every check() call. Mutating the returned value would corrupt subsequent calls.
Fix both application sites:
Field-level default now also runs cv_check_node on the copied value, so nested defaults are applied recursively.
Add regression test in test/inplace_default_deepcopy_test.lua.