Enhanced Forced-Sub to be chosen based on preferred Audio#524
Open
craitose wants to merge 1 commit intotapframe:devfrom
Open
Enhanced Forced-Sub to be chosen based on preferred Audio#524craitose wants to merge 1 commit intotapframe:devfrom
craitose wants to merge 1 commit intotapframe:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enhancement improves automatic forced‑subtitle selection.
The player now waits for addon subtitles to load before selecting built‑in subtitles, ensuring correct forced‑subtitle detection.
Forced subtitles are automatically selected based on the preferred audio language. If multiple forced tracks exist, the one matching the audio language is preferred. If no forced track exists, subtitles remain off unless manually selected. Full subtitles are never auto‑enabled when a forced track is present.
Scenarios:
Audio: JA, Forced: JA + EN → selects Forced JA
Audio: JA, Forced: EN only → selects none
Audio: JA, no forced tracks → selects none
Audio: JA, Forced: JA → selects Forced JA
Audio: EN, Forced: ES only → selects none