Fix trailer autoplay in background without resetting focus state#235
Open
kernexshadow wants to merge 2 commits intotapframe:devfrom
Open
Fix trailer autoplay in background without resetting focus state#235kernexshadow wants to merge 2 commits intotapframe:devfrom
kernexshadow wants to merge 2 commits intotapframe:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes trailer autoplay starting while the app is in the background (after pressing Home), and preserves the current focused/expanded context when returning to the app.
What changed
RESUMEDgating to trailer/autoplay flows in:ContentCard(classic focused/expanded poster flow)ModernHomeContent(expanded card and hero trailer autoplay flow)OnAppForegroundChangedMetaDetailsScreennow reports lifecycle foreground changesMetaDetailsViewModelcancels idle autoplay timer when app goes backgroundResult
Closes #234