This repository was archived by the owner on Mar 10, 2021. It is now read-only.
add network fqdn/alias table to known issues#359
Open
sergirubio wants to merge 3 commits intotango-controls:masterfrom
Open
add network fqdn/alias table to known issues#359sergirubio wants to merge 3 commits intotango-controls:masterfrom
sergirubio wants to merge 3 commits intotango-controls:masterfrom
Conversation
piogor
suggested changes
Oct 9, 2020
Collaborator
piogor
left a comment
piogor
left a comment
There was a problem hiding this comment.
Thanks, @sergirubio, there is a need for a small correction to avoid the only warning ;-).
Comment on lines
+70
to
+72
| - **known workaround**: it is possible to setup each device on a machine to use | ||
| an specific IP address (to run servers on different IP addresses he server host | ||
| must have multiple interfaces, tipically virtual ones). |
Collaborator
There was a problem hiding this comment.
It seem the identation has to be corrected (/home/travis/build/tango-controls/tango-doc/source/development/advanced/known-issues.rst:71: WARNING: Bullet list ends without a blank line; unexpected unindent.)
Suggested change
| - **known workaround**: it is possible to setup each device on a machine to use | |
| an specific IP address (to run servers on different IP addresses he server host | |
| must have multiple interfaces, tipically virtual ones). | |
| - **known workaround**: it is possible to setup each device on a machine to use | |
| an specific IP address (to run servers on different IP addresses he server host | |
| must have multiple interfaces, tipically virtual ones). |
Author
There was a problem hiding this comment.
hi piotr, I agree with the change
thanks
Collaborator
There was a problem hiding this comment.
@sergirubio, I think it is you who should apply the suggestion as I do not have write permission to ALBA repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.