refactor: remove type definitions that are not needed#73
Open
ForbesLindesay wants to merge 1 commit intotaneliang:masterfrom
Open
refactor: remove type definitions that are not needed#73ForbesLindesay wants to merge 1 commit intotaneliang:masterfrom
ForbesLindesay wants to merge 1 commit intotaneliang:masterfrom
Conversation
The random-words package already has type definitions, so we can just use those. No types from it are exposed, so it can be a devDependency. We are not using faker anywhere anymore, so it can be safely removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The random-words package already has type definitions, so we can just use those. No types from it are exposed, so it can be a devDependency.
We are not using faker anywhere anymore, so it can be safely removed.
I'd like to make some more substantial contributions, but thought. I'd start with this small housekeeping task. Is it possible to use stack-attack on a forked repository? I'm guessing that might be a little trickier to make work.