Bump pnpm, and ensure packages are 7 days old#19891
Bump pnpm, and ensure packages are 7 days old#19891RobinMalfait wants to merge 23 commits intomainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdated 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 63: The FreeBSD CI job installs pnpm@9.6.0 which conflicts with the
repository's packageManager "pnpm@10.33.0"; update the install command in the
FreeBSD CI step (the sudo npm install -g pnpm@9.6.0 --unsafe-perm=true
invocation in .github/workflows/release.yml) to install pnpm v10 (e.g.,
pnpm@10.33.0 or a v10 range) so the CI uses the same major version as
packageManager and avoids lockfile/feature mismatches; also scan the workflow
for any other pinned pnpm@9.x occurrences and align them to v10.x.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 2e396746-3f72-41e0-94f4-302fa60b2ef6
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
package.jsonpnpm-workspace.yaml
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@integrations/upgrade/upgrade-errors.test.ts`:
- Line 39: The test currently runs exec('git commit -m "before migration" ||
true') which is non-portable and can leave HEAD unborn; replace this with
explicit git user identity configuration and a deterministic commit: run
commands to set git config user.email and user.name locally (e.g., git config
user.email "test@example.com" && git config user.name "Test CI") before invoking
exec('git add -A' ) and exec('git commit -m "before migration"') (remove the ||
true). Apply the same fix where commits are performed in the utilities helper
(the code that calls exec for git commits/reset) so git reset --hard HEAD won't
run against an unborn HEAD.
In `@integrations/utils.ts`:
- Around line 454-459: The catch block in the wrapper around testCallback is
mutating the shared test function by calling Error.captureStackTrace(test) and
then rethrowing err, which doesn't update the thrown error's stack and can leak
state between tests; remove the entire try/catch so testCallback(context) is
awaited and any thrown error is propagated unchanged (i.e., delete
Error.captureStackTrace(test) and the catch that throws err), leaving the
original error and stack intact when invoking testCallback from this helper.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 3ddf80c3-ddae-42a5-ba93-e56d3f7667e1
📒 Files selected for processing (2)
integrations/upgrade/upgrade-errors.test.tsintegrations/utils.ts
7388266 to
69bc1ee
Compare
This also gives us the `minimumReleaseAge` (introduces in 10.16)
This will create an empty commit when there is nothing to commit, but we don't really care about that. We only care that files are committed if there are files such that we have a clean working directory.
In the test directly
I think `pnpm run` is injecting some environment variables (https://pnpm.io/cli/run#environment) based on the pnpm-workspace.yaml settings. You can at least see weird warnings in CI about it: ``` npm warn Unknown env config "catalog". This will stop working in the next major version of npm. See `npm help npmrc` for supported config options. npm warn Unknown env config "minimum-release-age". This will stop working in the next major version of npm. See `npm help npmrc` for supported config options. npm warn Unknown env config "npm-globalconfig". This will stop working in the next major version of npm. See `npm help npmrc` for supported config options. npm warn Unknown env config "verify-deps-before-run". This will stop working in the next major version of npm. See `npm help npmrc` for supported config options. npm warn Unknown env config "_jsr-registry". This will stop working in the next major version of npm. See `npm help npmrc` for supported config options. ``` Let's see if we can exec vitest directly
4a5cb18 to
c6b8efd
Compare
7f18edc to
03e0c32
Compare
35c74f5 to
a044c90
Compare
31e0cff to
6672f75
Compare
c88d522 to
a62b61d
Compare
This PR bumps pnpm to 10.33, we required at least version 10.16 for the
minimumReleaseAgesetting to take effect.We also now add the
minimumReleaseAgeto be 7 days, newer packages are not allowed.[ci-all]