Open
Conversation
There was a problem hiding this comment.
Pull request overview
Improves TestWaitPool so it runs faster on small hosts and avoids go vet warnings, while still validating WaitPool concurrency behavior.
Changes:
- Scale
startTrialsbased onruntime.NumCPU()(and reduce further under-race) to speed up the test on smaller machines. - Fix
t.Errorfformatting by printingmax.Load()instead of the atomic value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TestWaitPool now scales better to small hosts, and no longer triggers `go vet`. Signed-off-by: Alex Valiushko <alexvaliushko@tailscale.com> Change-Id: I97a2d22561468de14b17e09d557f212b6a6a6964
illotum
force-pushed
the
illotum/fix-wait-test
branch
from
0b2d447 to
f64bded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestWaitPool now scales better to small hosts,
and no longer triggers
go vet.Change-Id: I97a2d22561468de14b17e09d557f212b6a6a6964