tsidp-server.go: read ENV vars using Go#123
Merged
mikeodr merged 1 commit intotailscale:mainfrom Feb 18, 2026
Merged
Conversation
rschio
force-pushed
the
push-qqpywsxkupss
branch
from
7201f58 to
07e3044
Compare
mikeodr
requested changes
Feb 18, 2026
Collaborator
mikeodr
left a comment
mikeodr
left a comment
There was a problem hiding this comment.
Thanks for the PR, it's a good cleanup!
But I have one request for getting it updated to use an already set of maintained env functions that are used across Tailscale's codebase more broadly.
Collaborator
|
LGTM, just needs a squash and fix of the DCO signoff, thanks for the PR! |
Remove the script used to read environment variables in docker and instead read the variables using plain Go. This simplifies the container build and make it possible to use tools like Ko to build the container. Signed-off-by: Rodrigo Schio <r@schio.dev>
rschio
force-pushed
the
push-qqpywsxkupss
branch
from
2d98570 to
ae1341e
Compare
Contributor
Author
|
Done, thanks. |
mikeodr
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the script used to read environment variables in docker and instead read the variables using plain Go. This simplifies the container build and make it possible to use tools like Ko to build the container.
In a future PR one can change the container build to something like this: