feat(completion): adopt politty dispatcher mode#1343
Draft
dqn wants to merge 8 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: c2bb0fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Bump the politty pkg.pr override to the PR #491 head where generateCompletion's direct-API default returns to static, and drop the now-redundant static-mode pin from the completion test.
Code Metrics Report (packages/sdk)
Details | | main (a0d07a9) | #1343 (5dda241) | +/- |
|--------------------|----------------|-----------------|------|
| Coverage | 66.0% | 66.0% | 0.0% |
| Files | 394 | 394 | 0 |
| Lines | 13517 | 13517 | 0 |
| Covered | 8930 | 8930 | 0 |
| Code to Test Ratio | 1:0.4 | 1:0.4 | 0.0 |
| Code | 90255 | 90255 | 0 |
| Test | 39186 | 39186 | 0 |SDK Configure Bundle Size
Runtime Performance
Type Performance (instantiations)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopt politty dispatcher mode for SDK shell completion.
Main changes
generate-workerhelper during the SDK build.Dispatcher behavior
tailor-sdkbinary at completion time.tailor-sdkinstallations to provide their own completion behavior when the user's PATH points at them.tailor-sdk, completion is served by the bundled worker from that same project-local SDK package.Existing users
eval "$(tailor-sdk completion zsh)"only need to restart or reload their shell after upgrading SDK.tailor-sdkappears first on PATH in the project directory.Verification
1562.2 ms29.9 ms36.1 ms20.4 msNotes