feat(cli): add authconnection delete command#1310
Draft
toiroakr wants to merge 3 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: abcaeb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
⚡ pkg.pr.new@tailor-platform/sdk@tailor-platform/create-sdk
|
Add 'tailor authconnection delete' to remove an auth connection entirely, and clarify that 'authconnection revoke' now only invalidates tokens. Regenerate the @tailor-proto bindings to include DeleteAuthConnection (syncs tailor-proto to the current tailor-inc/proto).
Once the platform splits revoke (token-only) from delete, the deploy flow's revoke-then-create replacement would fail with AlreadyExists and its deletions would silently stop removing connections. Use DeleteAuthConnection for both, falling back to RevokeAuthConnection on platforms that do not implement it yet, where revoke still deletes the connection.
toiroakr
force-pushed
the
feat/auth-connection-delete
branch
from
adcfca6 to
3f53df5
Compare
Contributor
Author
|
Post-rollout cleanup: once the platform's revoke/delete split has rolled out to every environment, remove the |
…orms Older platforms have no DeleteAuthConnection RPC, where revoke still deletes the connection, so the CLI delete command now falls back to revoke on Unimplemented like deploy does. Document the version-dependent revoke behavior in the command notes, and fill the previously missing api subcommands table in the generated docs.
|
|
||
| feat(cli): add `authconnection delete` and make `authconnection revoke` token-only | ||
|
|
||
| `tailor authconnection delete` removes an auth connection entirely (configuration and tokens). `tailor authconnection revoke` now only invalidates the connection's tokens while keeping the connection so it can be re-authorized — previously revoke removed the connection entirely. `deploy` now uses delete when replacing or removing auth connections (falling back to revoke on platforms without it), so update the SDK before the platform's revoke/delete split rolls out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tailor authconnection deleteto remove an auth connection entirely (configuration + tokens). On older platforms without the new RPC it falls back to revoke, which still deletes there.tailor authconnection revokenow only invalidates the connection's tokens and keeps the connection so it can be re-authorized, matching the platform's revoke/delete split. The command notes call out that older platforms still delete on revoke.deploynow usesDeleteAuthConnectionwhen replacing or removing auth connections, falling back toRevokeAuthConnectionon platforms that do not implement it yet. Without this, deploys would fail withAlreadyExistsonce the platform split rolls out.@tailor-protobindings to includeDeleteAuthConnection. The regeneration tracks the current upstream proto, so it also picks up unrelated new upstream bindings (organization IP restriction, custom domains, workflow execution policies, etc.).Depends on
The platform-side
DeleteAuthConnectionRPC and token-only revoke behavior, which roll out separately. Until then,deployandauthconnection deletefall back to revoke (which still deletes on older platforms).Base
Stacked on #1309.