Skip to content

fix(http): map invalid response status to openai error #3439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laststylebender14 merged 1 commit into from
Jun 3, 2026
Merged

fix(http): map invalid response status to openai error #3439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions crates/forge_infra/src/http.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,11 @@ impl<F: forge_app::FileWriterInfra + 'static> ForgeHttpInfra<F> {
.text()
.await
.unwrap_or_else(|_| "Unable to read response body".to_string());
return Err(anyhow::anyhow!(error_body))
.with_context(|| format_http_context(Some(status), method, url));
return Err(anyhow::Error::from(
forge_app::dto::openai::Error::InvalidStatusCode(status.as_u16()),
))
.context(error_body)
.with_context(|| format_http_context(Some(status), method, url));
}

Ok(response)
Expand Down
6 changes: 4 additions & 2 deletions crates/forge_repo/src/provider/openai_responses/repository.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1568,7 +1568,7 @@ mod tests {
let mut fixture = MockServer::new().await;

let _mock = fixture
.mock_codex_responses_stream("/backend-api/codex/responses", vec![], 400)
.mock_codex_responses_stream("/backend-api/codex/responses", vec![], 429)
.await;

let codex_url = format!("{}/backend-api/codex/responses", fixture.url());
Expand All @@ -1593,8 +1593,10 @@ mod tests {
let actual = provider_impl
.chat(&ModelId::from("gpt-5.1-codex"), context)
.await;
let actual = actual.err().expect("chat should fail with status error");

assert!(actual.is_err());
let expected = Some(429);
assert_eq!(retry::get_api_status_code(&actual), expected);

Ok(())
}
Expand Down
Loading