Skip to content

[build] Fix editable build dependency compatibility #8789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yunusberndt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[build] Fix editable build dependency compatibility #8789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements_dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
cmake<4.0.0
setuptools<82
colorama
coverage
Pillow
Expand Down
12 changes: 10 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
# extra cmake args for C++ taichi_python extension.

import glob
import inspect
import multiprocessing
import os
import platform
Expand Down Expand Up @@ -82,7 +83,7 @@ def run(self):
super().run()
self.build_temp = os.path.join(root_dir, "_skbuild")
if os.path.exists(self.build_temp):
remove_tree(self.build_temp, dry_run=self.dry_run)
self._remove_tree_compat(self.build_temp)
generated_folders = (
"bin",
"dist",
Expand All @@ -95,7 +96,7 @@ def run(self):
)
for d in generated_folders:
if os.path.exists(d):
remove_tree(d, dry_run=self.dry_run)
self._remove_tree_compat(d)
generated_files = ["taichi/common/commit_hash.h", "taichi/common/version.h"]
generated_files += glob.glob("taichi/runtime/llvm/runtime_*.bc")
generated_files += glob.glob("python/taichi/_lib/core/*.so")
Expand All @@ -106,6 +107,13 @@ def run(self):
if not self.dry_run:
os.remove(f)

def _remove_tree_compat(self, path):
# setuptools/distutils changed remove_tree() signature across versions.
if "dry_run" in inspect.signature(remove_tree).parameters:
remove_tree(path, dry_run=self.dry_run)
elif not self.dry_run:
remove_tree(path)


def get_cmake_args():
import shlex
Expand Down
Loading