The new XmlReader which is able to read from several sources#948
Draft
Mingun wants to merge 11 commits intotafia:masterfrom
Draft
The new XmlReader which is able to read from several sources#948Mingun wants to merge 11 commits intotafia:masterfrom
XmlReader which is able to read from several sources#948Mingun wants to merge 11 commits intotafia:masterfrom
Conversation
… of several XML sources TODO: remaining questions about namespace resolving
…e new XmlReader
Now deserializing from BufRead requires 'static type (is that still true?)
failures:
serde-de:
resolve::resolve_custom_entity
--doc:
src\de\mod.rs - de::Deserializer<'de,R,E>::get_ref (line 2580)
src\de\resolver.rs - de::resolver::EntityResolver (line 13)
The new XmlReader captures DTD and resolves references, so that events never produced
Fixed:
resolve::resolve_custom_entity
…are parsed Remove previous test because it is covered by the new one
After removing `R` generic, some impl blocks began to have the same bounds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation that I have already mentioned several times. I decided to abandon renaming the
Reader->RawReaderbecause it can break dependents too much, and instead add a newXmlReaderthat will take over most of the low-level things usually not required in XML processing:It is more or less working, although there are several questions that it seems to me still need to be worked out:
unwrap()s are safeEntityResolvertrait is good enough. I would like to optimize some special cases, such as borrowing from parsed documentAt least the implementation is already mature enough to show it to the world and could be giving someone ideas. Currently I'm not sure when I can continue to working on it.