Skip to content

Minor improvements #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
breqwas wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Minor improvements #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
195761b
add mirror() and mirror_async() methods, and basic tests for them
breqwas Feb 24, 2015
444c331
- remove copypasted stuff
breqwas Mar 10, 2015
b371181
- tests for latest bugfixes
breqwas Mar 10, 2015
a05ea3e
spaces
breqwas Mar 10, 2015
abcee69
- it's perl -l, not perl -c
breqwas Mar 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/AnyEvent/HTTP/LWP/UserAgent.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ sub simple_request_async {
if($out_req->code < 200 || 300 <= $out_req->code) { # not success
$content .= $d;
} else {
local $\ = '';
print $fh $d or $cv->croak("Can't write to '$arg': $!");
}
return 1;
Expand Down Expand Up @@ -335,12 +336,14 @@ sub lwp_request2anyevent_request {
$self->cookie_jar->add_cookie_header($in_req);
}

my $in_headers = $in_req->headers;
my $out_headers = {};
$in_headers->scan( sub {
my $scan_sub = sub {
my ($header, $value) = @_;
$out_headers->{$header} = $value;
} );
};

$self->default_headers()->scan($scan_sub);
$in_req->headers()->scan($scan_sub);

# if we will use some code like
# local $AnyEvent::HTTP::USERAGENT = $useragent;
Expand Down Expand Up @@ -552,4 +555,3 @@ L<LWP::Protocol::Coro::http>
Yasutaka Atarashi

=cut

88 changes: 88 additions & 0 deletions t/mirror.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
use strict;
use Test::More;
use File::Slurp qw(read_file);
use AnyEvent::HTTP::LWP::UserAgent;

BEGIN {
eval q{ require Test::TCP } or plan skip_all => 'Could not require Test::TCP';
eval q{ require HTTP::Server::Simple::CGI } or plan skip_all => 'Could not require HTTP::Server::Simple::CGI';
}

{
package HTTP::Server::Simple::Test;
our @ISA = 'HTTP::Server::Simple::CGI';

sub print_banner { }

my $bigdata = join(", ", 0 .. 10_000);
our $content = <<__HTML__;
<html>
<head>
<title>Test Web Page</title>
<base href="http://www.example.com/">
</head>
<body>
<p>$bigdata</p>
<p>Cheerilee is the best pony</p>
</body>
</html>
__HTML__

sub handle_request {
my ($self, $cgi) = @_;

print "HTTP/1.0 200 OK\r\n";
print "Content-Type: text/html\r\n";
print "Set-Cookie: test=abc; path=/\r\n";
print "X-Gotcha: ok\r\n" if $cgi->http("http-x-throw");
print "\r\n";
print $content;
}
}

plan tests => 9;

Test::TCP::test_tcp(
server => sub {
my $port = shift;
my $server = HTTP::Server::Simple::Test->new($port);
$server->run;
},
client => sub {
my $port = shift;
{
# basic
my $fname = "/tmp/mirror_basic_$$";
my $ua = AnyEvent::HTTP::LWP::UserAgent->new();
my $res = $ua->mirror("http://localhost:$port/", $fname);
ok $res->is_success, 'basic: is_success';
is $res->content, '', 'basic: empty content';
is read_file($fname), $HTTP::Server::Simple::Test::content, 'basic: valid file';
unlink $fname;
}
{
# perl -l
local $\ = "\n";
my $fname = "/tmp/mirror_newlines_$$";
my $ua = AnyEvent::HTTP::LWP::UserAgent->new();
my $res = $ua->mirror("http://localhost:$port/", $fname);
ok $res->is_success, 'perl -l: is_success';
is read_file($fname), $HTTP::Server::Simple::Test::content, 'perl -l: valid file';
unlink $fname;
}
{
# headers
my $fname = "/tmp/mirror_defheaders_$$";
my $ua = AnyEvent::HTTP::LWP::UserAgent->new();
$ua->default_header("X-Throw" => "1");
my $res = $ua->mirror("http://localhost:$port/", $fname);
ok $res->is_success, 'headers: is_success';
is read_file($fname), $HTTP::Server::Simple::Test::content, 'headers: valid file';
ok $res->header("X-Gotcha"), "headers: default header was passed and processed";
unlink $fname;
}

},
);

pass "Cheerilee is the best pony";