feat(xfs): improve IsSamePath with abs path and refactor util.go to use it #367
Open
feat(xfs): improve IsSamePath with abs path and refactor util.go to use it #367
Conversation
…se it - IsSamePath now resolves both paths to absolute paths before comparison, so mixed relative/absolute or dot-segment paths pointing to the same location are correctly considered equal - Add comprehensive test cases for IsSamePath covering abs/rel, dot-segments, symlink-free equivalence, and cross-platform slash normalization - Refactor prepareOutdir in util.go to use IsSamePath instead of manually calling filepath.Abs + xfs.CleanSlashPath, simplifying the logic
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #367 +/- ##
==========================================
- Coverage 73.91% 73.90% -0.01%
==========================================
Files 87 87
Lines 8664 8673 +9
==========================================
+ Hits 6404 6410 +6
Misses 1700 1700
- Partials 560 563 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Kybxd
reviewed
Mar 18, 2026
| // remove all *.proto file but not Imports | ||
| imports := make(map[string]bool) | ||
| // Collect all glob-expanded import paths. | ||
| var importPaths []string |
Collaborator
There was a problem hiding this comment.
Using map[string]bool makes sense here because one importPath may match mutiple patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xfs.IsSamePathimprovementrelative/absolute or dot-segment paths pointing to the same location
are correctly considered equal
CleanSlashPathcomparison iffilepath.AbsfailsTest coverage
internal/x/xfs/path_test.gocovering:./foo/../bar)prepareOutdirrefactorfilepath.Abs+xfs.CleanSlashPathmap-based approachwith
xfs.IsSamePathvia anisImportedclosurefilepath.Abscalls and their associated error handling,making the logic simpler and more readable