log(BREAKING!): replace tableau logger with an interface which zap.SugaredLogger implements#347
Open
log(BREAKING!): replace tableau logger with an interface which zap.SugaredLogger implements#347
zap.SugaredLogger implements#347Conversation
dee3a23 to
7bf95fa
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 75.12% 76.44% +1.32%
==========================================
Files 85 79 -6
Lines 8571 8233 -338
==========================================
- Hits 6439 6294 -145
+ Misses 1565 1396 -169
+ Partials 567 543 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7bf95fa to
3def928
Compare
zap.SugaredLogger implementszap.SugaredLogger implements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗BREAKING CHANGE
SetLoggerto set it to any logger if they want.Mode,Level,SetDriver.<Log>and<Log>wmethods are also removed since they are not used. Only<Log>fmethods are left.Compatibility resolution
log.SetLoggerto customize tableau logs if you imports tableau package in your project, otherwise tableau outputs no logs.