Skip to content

log(BREAKING!): replace tableau logger with an interface which zap.SugaredLogger implements#347

Open
Kybxd wants to merge 3 commits intomasterfrom
zino.logger-iface
Open

log(BREAKING!): replace tableau logger with an interface which zap.SugaredLogger implements#347
Kybxd wants to merge 3 commits intomasterfrom
zino.logger-iface

Conversation

@Kybxd
Copy link
Copy Markdown
Collaborator

@Kybxd Kybxd commented Jan 29, 2026

❗BREAKING CHANGE

  • The default logger of tableau is an interface now, instead of a struct. Users can call SetLogger to set it to any logger if they want.
  • Unnecessary methods are removed, including Mode, Level, SetDriver. <Log> and <Log>w methods are also removed since they are not used. Only <Log>f methods are left.

Compatibility resolution

  • Nothing to do if you use tableau executable file
  • You can use log.SetLogger to customize tableau logs if you imports tableau package in your project, otherwise tableau outputs no logs.

@Kybxd Kybxd force-pushed the zino.logger-iface branch from dee3a23 to 7bf95fa Compare January 29, 2026 07:46
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.44%. Comparing base (1da426f) to head (a64463a).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/importer/excel.go 33.33% 1 Missing and 1 partial ⚠️
log/driver/zapdriver/logger.go 33.33% 2 Missing ⚠️
cmd/tableauc/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   75.12%   76.44%   +1.32%     
==========================================
  Files          85       79       -6     
  Lines        8571     8233     -338     
==========================================
- Hits         6439     6294     -145     
+ Misses       1565     1396     -169     
+ Partials      567      543      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kybxd Kybxd force-pushed the zino.logger-iface branch from 7bf95fa to 3def928 Compare January 29, 2026 07:48
@Kybxd Kybxd changed the title feat: replace tableau logger with an interface which zap.SugaredLogger implements log(BREAKING!): replace tableau logger with an interface which zap.SugaredLogger implements Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants