fix: quote tag labels containing spaces or commas; add e2e test suite

The Tableau server splits unquoted tag labels on spaces and commas
(via TagUtil.parseTags), so "Yearly Sales" becomes two tags "Yearly"
and "Sales". Wrapping labels in double quotes prevents the split; the
server strips the quotes before storing.

Also adds the first e2e test infrastructure to the repo:
- test_e2e/ directory with a session-scoped server fixture reading
  credentials from env vars (TABLEAU_SERVER, TABLEAU_SITE,
  TABLEAU_TOKEN, TABLEAU_TOKEN_NAME, TABLEAU_PROJECT)
- test_e2e/test_tagging.py validates the tag quoting fix against a
  real Tableau server
- contributing.md documents how to run unit and e2e tests

Fixes #1738

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: jacalata

contributing.md

@@ -1,25 +1,55 @@
-# Contributing
-
-We welcome contributions to this project!
-
-Contribution can include, but are not limited to, any of the following:
-
-* File an Issue
-* Request a Feature
-* Implement a Requested Feature
-* Fix an Issue/Bug
-* Add/Fix documentation
-
-## Issues and Feature Requests
-
-To submit an issue/bug report, or to request a feature, please submit a [GitHub issue](https://github.com/tableau/server-client-python/issues) to the repo.
-
-If you are submitting a bug report, please provide as much information as you can, including clear and concise repro steps, attaching any necessary
-files to assist in the repro.  **Be sure to scrub the files of any potentially sensitive information.  Issues are public.**
-
-For a feature request, please try to describe the scenario you are trying to accomplish that requires the feature.  This will help us understand
-the limitations that you are running into, and provide us with a use case to know if we've satisfied your request.
-
-### Making Contributions
-
-Refer to the [Developer Guide](https://tableau.github.io/server-client-python/docs/dev-guide) which explains how to make contributions to the TSC project.
+# Contributing
+
+We welcome contributions to this project!
+
+Contribution can include, but are not limited to, any of the following:
+
+* File an Issue
+* Request a Feature
+* Implement a Requested Feature
+* Fix an Issue/Bug
+* Add/Fix documentation
+
+## Issues and Feature Requests
+
+To submit an issue/bug report, or to request a feature, please submit a [GitHub issue](https://github.com/tableau/server-client-python/issues) to the repo.
+
+If you are submitting a bug report, please provide as much information as you can, including clear and concise repro steps, attaching any necessary
+files to assist in the repro.  **Be sure to scrub the files of any potentially sensitive information.  Issues are public.**
+
+For a feature request, please try to describe the scenario you are trying to accomplish that requires the feature.  This will help us understand
+the limitations that you are running into, and provide us with a use case to know if we've satisfied your request.
+
+### Making Contributions
+
+Refer to the [Developer Guide](https://tableau.github.io/server-client-python/docs/dev-guide) which explains how to make contributions to the TSC project.
+
+## Running Tests
+
+### Unit tests
+
+```bash
+pip install -e ".[test]"
+pytest
+```
+
+### End-to-end tests
+
+E2e tests run against a real Tableau server and are kept in `test_e2e/`. They are excluded from the default `pytest` run.
+
+**Required environment variables:**
+
+| Variable | Description |
+|---|---|
+| `TABLEAU_SERVER` | Server URL, e.g. `https://10ax.online.tableau.com/` |
+| `TABLEAU_SITE` | Site content URL |
+| `TABLEAU_TOKEN` | Personal access token value |
+| `TABLEAU_TOKEN_NAME` | Personal access token name |
+| `TABLEAU_PROJECT` | Project to publish test content into (defaults to `Default`) |
+
+**Run:**
+
+```bash
+TABLEAU_SERVER=https://... TABLEAU_SITE=mysite TABLEAU_TOKEN=... TABLEAU_TOKEN_NAME=mytoken TABLEAU_PROJECT="My Project" \
+pytest test_e2e/
+```

pyproject.toml

@@ -68,6 +68,7 @@ exclude = ['/bin/']
 [tool.pytest.ini_options]
 testpaths = ["test"]
 addopts = "--junitxml=./test.junit.xml"
+markers = ["e2e: mark test as end-to-end (requires a real Tableau server)"]
 
 [tool.versioneer]
 VCS = "git"

test_e2e/__init__.py

@@ -0,0 +1,32 @@
+import os
+import pytest
+import tableauserverclient as TSC
+
+
+def pytest_configure(config):
+    config.addinivalue_line("markers", "e2e: mark test as end-to-end (requires a real Tableau server)")
+
+
+@pytest.fixture(scope="session")
+def server():
+    """
+    Authenticated TSC server session for e2e tests.
+
+    Required environment variables:
+        TABLEAU_SERVER   — server URL, e.g. https://10ax.online.tableau.com
+        TABLEAU_SITE     — site content URL
+        TABLEAU_TOKEN    — personal access token value
+        TABLEAU_TOKEN_NAME — personal access token name
+    """
+    url = os.environ.get("TABLEAU_SERVER")
+    site = os.environ.get("TABLEAU_SITE", "")
+    token = os.environ.get("TABLEAU_TOKEN")
+    token_name = os.environ.get("TABLEAU_TOKEN_NAME")
+
+    if not all([url, token, token_name]):
+        pytest.skip("E2E tests require TABLEAU_SERVER, TABLEAU_TOKEN, and TABLEAU_TOKEN_NAME env vars")
+
+    server = TSC.Server(url, use_server_version=True)
+    auth = TSC.PersonalAccessTokenAuth(token_name, token, site)
+    with server.auth.sign_in(auth):
+        yield server

test_e2e/assets/WorkbookWithoutExtract.twbx

@@ -0,0 +1,78 @@
+"""
+E2E tests for tag operations against a real Tableau server.
+
+Run with:
+    TABLEAU_SERVER=https://... TABLEAU_SITE=mysite TABLEAU_TOKEN=... TABLEAU_TOKEN_NAME=... \
+    pytest test_e2e/test_tagging.py -v
+"""
+import os
+from pathlib import Path
+
+import pytest
+import tableauserverclient as TSC
+
+ASSETS_DIR = Path(__file__).parent / "assets"
+SAMPLE_WORKBOOK = ASSETS_DIR / "WorkbookWithoutExtract.twbx"
+
+pytestmark = pytest.mark.e2e
+
+
+@pytest.fixture(scope="module")
+def workbook(server):
+    """Publish a workbook for tagging tests, clean up after.
+
+    Uses TABLEAU_PROJECT env var if set, otherwise falls back to the first
+    project named 'Default' or 'Personal Work', then the first available project.
+    """
+    project_name = os.environ.get("TABLEAU_PROJECT", "Default")
+    opts = TSC.RequestOptions()
+    opts.filter.add(TSC.Filter(TSC.RequestOptions.Field.Name, TSC.RequestOptions.Operator.Equals, project_name))
+    projects, _ = server.projects.get(opts)
+    if not projects:
+        pytest.skip(f"Project {project_name!r} not found — set TABLEAU_PROJECT env var")
+    project = projects[0]
+
+    wb = TSC.WorkbookItem(name="tsc-e2e-tagging-test", project_id=project.id)
+    wb = server.workbooks.publish(wb, SAMPLE_WORKBOOK, TSC.Server.PublishMode.Overwrite)
+    yield wb
+    server.workbooks.delete(wb.id)
+
+
+def test_tag_with_spaces_stored_as_single_tag(server, workbook):
+    """A tag containing a space must be stored as one tag, not split on the space."""
+    spaced_tag = "Yearly Sales"
+    server.workbooks.add_tags(workbook, spaced_tag)
+    updated = server.workbooks.get_by_id(workbook.id)
+    try:
+        assert spaced_tag in updated.tags, (
+            f"Tag '{spaced_tag}' not found in {updated.tags!r} — was it split on the space?"
+        )
+        assert "Yearly" not in updated.tags, "Tag was incorrectly split — 'Yearly' should not be a separate tag"
+        assert "Sales" not in updated.tags, "Tag was incorrectly split — 'Sales' should not be a separate tag"
+    finally:
+        server.workbooks.delete_tags(workbook, spaced_tag)
+
+
+def test_tag_with_comma_stored_as_single_tag(server, workbook):
+    """A tag containing a comma must be stored as one tag, not split on the comma."""
+    comma_tag = "Sales,Marketing"
+    server.workbooks.add_tags(workbook, comma_tag)
+    updated = server.workbooks.get_by_id(workbook.id)
+    try:
+        assert comma_tag in updated.tags, (
+            f"Tag '{comma_tag}' not found in {updated.tags!r} — was it split on the comma?"
+        )
+    finally:
+        server.workbooks.delete_tags(workbook, comma_tag)
+
+
+def test_multiple_tags_including_spaced(server, workbook):
+    """Adding multiple tags where one has a space should all round-trip correctly."""
+    tags = ["simple", "Yearly Sales", "another tag"]
+    server.workbooks.add_tags(workbook, tags)
+    updated = server.workbooks.get_by_id(workbook.id)
+    try:
+        for tag in tags:
+            assert tag in updated.tags, f"Tag '{tag}' not found in {updated.tags!r}"
+    finally:
+        server.workbooks.delete_tags(workbook, tags)