fix: quote tag labels containing spaces or commas in XML request

The server's TagUtil.parseTags splits unquoted labels on spaces and
commas, causing tags like "Yearly Sales" to be stored as two separate
tags. Wrapping labels in double quotes prevents the split; the server
strips the quotes before storing.

Fixes #1738

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: jacalata

tableauserverclient/server/request_factory.py

@@ -611,7 +611,7 @@ def update_req(self, schedule_item):
             intervals_element = ET.SubElement(frequency_element, "intervals")
             if hasattr(interval_item, "interval"):
                 for interval in interval_item._interval_type_pairs():
-                    (expression, value) = interval
+                    expression, value = interval
                     single_interval_element = ET.SubElement(intervals_element, "interval")
                     single_interval_element.attrib[expression] = value
         return ET.tostring(xml_request)
@@ -921,13 +921,21 @@ def update_req(self, table_item):
 content_types = Iterable["ColumnItem | DatabaseItem | DatasourceItem | FlowItem | TableItem | WorkbookItem"]
 
 
+def _encode_tag_label(tag: str) -> str:
+    # The server splits unquoted labels on spaces or commas. Wrap in double
+    # quotes so labels containing spaces are stored as a single tag.
+    if " " in tag or "," in tag:
+        return f'"{tag}"'
+    return tag
+
+
 class TagRequest:
     def add_req(self, tag_set):
         xml_request = ET.Element("tsRequest")
         tags_element = ET.SubElement(xml_request, "tags")
         for tag in tag_set:
             tag_element = ET.SubElement(tags_element, "tag")
-            tag_element.attrib["label"] = tag
+            tag_element.attrib["label"] = _encode_tag_label(tag)
         return ET.tostring(xml_request)
 
     @_tsrequest_wrapped
@@ -936,7 +944,7 @@ def batch_create(self, element: ET.Element, tags: set[str], content: content_typ
         tags_element = ET.SubElement(tag_batch, "tags")
         for tag in tags:
             tag_element = ET.SubElement(tags_element, "tag")
-            tag_element.attrib["label"] = tag
+            tag_element.attrib["label"] = _encode_tag_label(tag)
         contents_element = ET.SubElement(tag_batch, "contents")
         for item in content:
             content_element = ET.SubElement(contents_element, "content")

test/test_tagging.py

@@ -21,7 +21,9 @@ def get_server() -> TSC.Server:
     return server
 
 
-def add_tag_xml_response_factory(tags: Iterable[str]) -> str:
+def add_tag_xml_response_factory(tags: Iterable[str] | str) -> str:
+    if isinstance(tags, str):
+        tags = [tags]
     root = ET.Element("tsResponse")
     tags_element = ET.SubElement(root, "tags")
     for tag in tags:
@@ -242,3 +244,15 @@ def test_tags_batch_delete(get_server) -> None:
         tag_result = server.tags.batch_delete(tags, content)
 
     assert set(tag_result) == set(tags)
+
+
+def test_tag_with_spaces_is_quoted_in_request() -> None:
+    """Tags containing spaces must be quoted in the XML request to prevent server-side splitting."""
+    from tableauserverclient.server.request_factory import RequestFactory
+
+    tag_set = {"Yearly Sales", "simple"}
+    xml_bytes = RequestFactory.Tag.add_req(tag_set)
+    root = ET.fromstring(xml_bytes)
+    labels = {tag.get("label") for tag in root.findall(".//tag")}
+    assert '"Yearly Sales"' in labels
+    assert "simple" in labels