Skip to content

ci: silence cargo-deny toolchain-override stack trace (#81)#167

Merged
StefanSteiner merged 1 commit into
tableau:mainfrom
StefanSteiner:fix/81-cargo-deny-toolchain-noise
Jun 29, 2026
Merged

ci: silence cargo-deny toolchain-override stack trace (#81)#167
StefanSteiner merged 1 commit into
tableau:mainfrom
StefanSteiner:fix/81-cargo-deny-toolchain-noise

Conversation

@StefanSteiner

Copy link
Copy Markdown
Contributor

Closes #81 (Finding 1).

Problem

The cargo-deny CI job emits an alarming — but non-fatal — stack trace on every run:

error: override toolchain 'stable-x86_64-unknown-linux-musl' is not installed
Caused by:
    the toolchain file at '/github/workspace/rust-toolchain.toml' specifies an uninstalled toolchain
Stack backtrace:
   ...

The EmbarkStudios/cargo-deny-action@v2 image ships a pre-installed stable toolchain, but its rustup show step evaluates rust-toolchain.toml's override before that toolchain is registered. rustup show exits non-zero with the trace; the action doesn't propagate the code, then installs stable and runs cleanly. The job is green — the trace is just ~20 lines of noise per run.

Fix

Pin RUSTUP_TOOLCHAIN: stable as a job-level env on the deny job (Option 1 from the issue — the smallest patch). This bypasses the rust-toolchain.toml override probe inside the action's container, so the log stays clean.

Enforcement unchanged

cargo deny check --all-features --workspace still runs against the full workspace. Verified locally with RUSTUP_TOOLCHAIN=stable cargo deny check:

advisories ok, bans ok, licenses ok, sources ok

Scope

Finding 1 only. Finding 2 (the bitflags 1.x/2.x duplicate-version warn) is left as-is — it's upstream-blocked (plotterscore-graphics still pins bitflags 1.3.2) and the issue marks it optional. No license/advisory enforcement change.

🤖 Generated with Claude Code

The EmbarkStudios/cargo-deny-action@v2 image ships a pre-installed
`stable` toolchain, but its `rustup show` step evaluates
rust-toolchain.toml's override before that toolchain is registered,
emitting a non-fatal but alarming 'override toolchain ... is not
installed' stack trace on every CI run. Pinning RUSTUP_TOOLCHAIN=stable
on the deny job bypasses the override probe so the log stays clean.

Enforcement is unchanged: `cargo deny check --all-features --workspace`
still runs against the full workspace (verified locally: advisories /
bans / licenses / sources all ok). The bitflags duplicate-version
warning (Finding 2) is left as-is — it's an upstream-blocked `warn`,
not a failure.
@StefanSteiner StefanSteiner merged commit 403f66f into tableau:main Jun 29, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: clean up cargo-deny noise (toolchain probe error + bitflags duplicate)

1 participant