Skip to content

Conversation

@tab
Copy link
Owner

@tab tab commented Jan 23, 2026

Add ANSI escape sequence to clear line before updating spinner display

Add ANSI escape sequence to clear line before updating spinner display
@tab tab self-assigned this Jan 23, 2026
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.29%. Comparing base (c25390d) to head (e6b36d4).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/app/cli/spinner/spinner.go 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   87.90%   87.29%   -0.61%     
==========================================
  Files          23       23              
  Lines        1149     1149              
==========================================
- Hits         1010     1003       -7     
- Misses        116      123       +7     
  Partials       23       23              
Files with missing lines Coverage Δ
internal/app/cli/spinner/spinner.go 86.66% <0.00%> (-11.67%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tab tab requested a review from Copilot January 23, 2026 16:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a display issue in the spinner component by adding an ANSI escape sequence to properly clear the terminal line before updating the spinner display. This prevents visual artifacts when the spinner message changes to a shorter string.

Changes:

  • Added \033[K escape sequence to clear the line from cursor to end before printing the spinner frame and message

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tab tab merged commit e6c5771 into master Jan 23, 2026
8 of 9 checks passed
@tab tab deleted the fix/loader branch January 23, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants