Open
Conversation
Owner
|
Hi @nomuus Thank you so much for this! I haven't had a chance to go over it properly (looks amazing at first glance) but wanted to let you know I am looking at it and will merge your changes along with some other updates into the next version (have added some other methods / frameworks and did a little tidying). Really appreciate the effort and contribution. I will of course credit you (unless you don't want me to) for the updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the code to handle paths and file operations in a more OS-independent manner. I deliberately did not refactor too deeply and tried to keep the general style intact. It's not the most elegant per se, but it should allow compiling payloads on a Linux host.
It adds a new argument to optionally fix the project file's target framework moniker which makes support for Linux easier than modifying them manually (the available argument choices are taken directly from the Microsoft site). There may be other means of achieving this end directly via dotnet core but I've not investigated any further.
More details are in the
Linux.mdfile.Disclaimer... I've not extensively tested as this was a modification done this afternoon in order to suit my use case.