ib-tb: support magic keyboard backlight#4
Open
Redecorating wants to merge 1 commit into
Open
Conversation
Member
Author
|
Setting as draft while I figure out how to get it to change the brightness like windows does. |
Member
Author
|
It's been tested on MBP16,1 and MBP16,2 |
Member
Author
|
drafting again as it seems to print backtraces on mbp15,1 (although the touchbar was still working). Also, its now been tested on mbp16,3 |
alex-007
reviewed
Oct 24, 2021
Member
|
@Redecorating Is this ready to merge? |
Member
Author
|
The backlight doesn't get freed when the module is unloaded, I'll try to fix that tomorrow. |
MacBookPro16,1/2/3/4 have the magic keyboard, with the keyboard backlight controlled via the Touch Bar Backlight USB device. We check that the internal keyboard's USB product ID matches that of models with the magic keyboard, and then we create a sysfs led class dev that controls the backlight.
Member
Author
|
@aunali1 it's ready now |
|
is this going to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MacBookPro16,1/2/3/4 and MacBookAir9,1 have the magic keyboard, with the
keyboard backlight controlled via the Touch Bar Backlight USB device.
We check that the internal keyboard's USB product ID matches that of
models with the magic keyboard, and then we create a sysfs led class
dev.
When setting the brightness to 15 (one less than the max of 16), itseems to have about a 50% chance of setting it to dim instead. This
doesn't happen for other values.