feat: promote eval to top-level command, add --frame for iframes#200
Open
sfc-gh-mochen wants to merge 8 commits intoszymdzum:mainfrom
Open
feat: promote eval to top-level command, add --frame for iframes#200sfc-gh-mochen wants to merge 8 commits intoszymdzum:mainfrom
sfc-gh-mochen wants to merge 8 commits intoszymdzum:mainfrom
Conversation
- Remove session.json file write on stop - Remove offline session fallback from network commands - Delete unused output.ts module - Update skill to discourage premature stop calls - Remove 'save output' references from UI messages - Demote 'bdg stop' in command listings (show peek/tail first) - Update golden workflow test to use peek instead of session.json - Users should use bdg peek to inspect telemetry data
# Conflicts: # package-lock.json
Add Playwright-style pseudo-selectors:
- :has-text("text") - element contains text (case-insensitive)
- :text("text") - smallest element with exact text
- :text-is("text") - exact text match (case-sensitive)
- :visible - element is visible
Remove nodeId caching layer:
- Delete DomElementResolver and QueryCacheManager
- Remove index-based operations (bdg dom click 0)
- Always use selectors with optional --index flag
Bug fixes:
- Fix "Object reference chain is too long" in bdg dom eval by handling
non-serializable DOM elements gracefully
- Fix script execution errors by embedding QUERY_ELEMENTS_HELPER inside
each IIFE instead of concatenating before it
- Update "Next steps" to show --index when multiple matches found
- Add Playwright Selectors section with :has-text, :text, :text-is, :visible - Explain why Playwright selectors replace 2-step query+index workflow - Update Form Interaction to show selector-based approach with --index - Document that dom eval now handles DOM elements gracefully - Remove references to index-based operations (bdg dom fill 0) - Add 'Click Button by Text' pattern example
- Add --chrome-ws-url option to screenshot command for direct CDP connection without daemon - Add top-level `bdg screenshot` alias for `dom screenshot` - Create directMode module for one-shot CDP commands
* fix: remove --chrome-ws-url from root command to fix subcommand option conflict The --chrome-ws-url option was defined on both the root program (via applyCollectorOptions in registerStartCommands) and on the dom screenshot subcommand. This caused Commander.js to parse the option on the root command instead of passing it to the subcommand handler. The fix removes --chrome-ws-url from applyCollectorOptions since: 1. The start command (root) is for starting new sessions with URLs 2. Direct mode (--chrome-ws-url) is only relevant for dom/cdp commands that connect to existing Chrome instances This fixes: bdg dom screenshot --chrome-ws-url <url> now works correctly. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: add `bdg electron` command for Electron app automation Add support for connecting to running Electron apps via CDP: - `bdg electron` - Connect to Electron on default port 9229 - `bdg electron --list` - List available Electron targets - `bdg electron --port <port>` - Connect to specific port - `bdg electron --target <id>` - Connect to specific target After connecting, all DOM commands work normally (screenshot, query, eval, click, etc.) through the daemon session. New files: - src/connection/electronDiscovery.ts - Target discovery functions - src/commands/electron.ts - The electron command Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…e targeting - Move `bdg dom eval` to `bdg eval` as a top-level command - Add FrameOptions interface and --frame flag for DOM commands to target iframes - Add error logging utility - Update all references, formatters, messages, and tests
sfc-gh-mochen
force-pushed
the
mochen-eval-and-frame
branch
from
8eeaf90 to
2083fea
Compare
4 tasks
Owner
|
Hey @sfc-gh-mochen, thanks for the substantial work here. I've been catching up on the backlog and reviewed all three related PRs (#169, #199, #200). The features are solid, but these PRs have a lot of overlap and bundled changes that make them hard to merge safely. Here's where things stand: Already merged:
The ask:
Issues to address in the DOM refactor:
For electron.ts specifically:
Re: #169 - since #200 is a superset, I'd suggest closing #169 once #200 is split and the DOM refactor PR is ready. Re: #199 (@sfc-gh-adsaxena's WebSocket capture) - the websocket feature itself is great, but it also bundles the same DOM refactor. Once your DOM refactor PR lands, the websocket PR can be rebased cleanly onto it. I'll comment on #199 separately. Breaking changes are fine. Happy to help review the split PRs. Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bdg dom evaltobdg evalas a top-level commandFrameOptionsinterface and--frameflag for DOM commands to target iframessrc/utils/errorLog.ts)Test plan
npm run build)bdg eval "document.title"to verify top-level eval worksbdg dom query "selector" --frame "iframe"to verify iframe targeting