feat(api): align REST endpoints with gRPC, introduce DTOs and refactor controllers #43#52
Open
Seraphim200001 wants to merge 5 commits into
Open
feat(api): align REST endpoints with gRPC, introduce DTOs and refactor controllers #43#52Seraphim200001 wants to merge 5 commits into
Seraphim200001 wants to merge 5 commits into
Conversation
- added missing endpoints (models, history, random-additive-walk) - replaced direct DB access with InstrumentModelManager - introduced request/response DTOs - aligned REST responses with gRPC semantics
- added missing endpoints (models, history, random-additive-walk) - replaced direct DB access with InstrumentModelManager - introduced request/response DTOs - aligned REST responses with gRPC semantics
szigh
reviewed
Mar 30, 2026
Owner
There was a problem hiding this comment.
Could you please add back the csproj
szigh
reviewed
Mar 30, 2026
| !README.md | ||
| !LOGGING.md | ||
| !TESTING.md | ||
| /MarketData/MarketData.csproj |
szigh
requested changes
Mar 30, 2026
Owner
szigh
left a comment
There was a problem hiding this comment.
We need to update the test project to use the new DTOs - it shouldn't be a big task but let me know if you can't do it and I will update.
Same with adding new tests for the new endpoints you added.
Good idea using the same service that gRPC uses (rather than directly accessing the dbContext)
- adding a third controller is a good shout. I will probably do the same with proto at some point (3 controllers/protos for Instruments+Models+Prices).
Thanks for the contribution
fix gitignore rmeove /MarketData/MarketData.csproj
Author
|
@szigh I’m so sorry, but I’ve unfortunately fallen ill, so my work will be a little delayed. If you don’t mind waiting, I’ll finish everything as soon as I’m back! However, if you’d like to finish earlier, you’re welcome to start on the test cases yourself. Thank you so much for your understanding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work on Ticket: #43
feat(api): align REST endpoints with gRPC, introduce DTOs and refactor controllers
Added missing REST endpoints for full parity with gRPC:
Refactored existing controllers to use IInstrumentModelManager:
Introduced DTOs across controllers:
Aligned REST responses with gRPC semantics:
Improved API consistency and maintainability: