Simplify public API; refactor helper functions for keep-alive handling#22
Merged
Conversation
Simplify applications by adding a helper function for obtaining URL path segments by index.
The public terminate() method exposes an optional switch (request_complete) to indicate the completeness of request processing. Based on this switch, a keep-alive connection is forcefully closed if the request body is partially processed. Such an approach is needed to avoid incorrectly parsing a subsequent requests with invalid framing. This commit removes the requirement for applications to know if the processing of a request is complete. Instead, rely on existing content-length validation logic to determine if a payload is fully processed. The following changes were added: - new state machine variable `_is_req_complete` to indicate completeness - update usages of the `terminate()` method to only accept status codes - new terminal state for updating response headers for keep-alive connections - the state machine is considered to reach a terminal state regardless of status code - new helper for resetting response body producer - remove member `aborted`; keep-alive connection is only based on request process completeness
`set_response_body` may be invoked multiple times during the lifecycle of a connection. Ensure that the response handler is reset every time the setter is called, to avoid a stale handler to be reused. Additionally, accept an empty/undefined response body, and set content-length to 0 accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.