Refactor early termination behavior and multipart response generation; add minor improvements#21
Merged
Conversation
Rename `get_url_encoded_query_param` to `get_query_param` and make it an instance method to simplify the usage.
Handle early termination requested by the user application when processing chunked or multipart requests. Stop processing the payload immediately when the state machine is terminated by the routing handler. Restructure route handler for file uploads, and create a helper function for identifying multipart requests. Move path validation logic to the beginning.
Convert `generate_multipart_response()` from a state-machine state into a helper function. The previous design required wrapper lambdas to adapt multipart response generation to the state handler interface, which expects only an `rx` argument. By moving multipart generation into a helper, applications can invoke it directly without returning an additional callback. This also unifies multipart route responses and early state machine termination under the same response handling path, eliminating ambiguous state transitions.
Reject file paths with a trailing / character, create tests for the validation function and the file server module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.