Add support for 32bit systems by falling back to std::unordered_map#56
Merged
ayzk merged 1 commit intoszcompressor:masterfrom May 27, 2024
Merged
Add support for 32bit systems by falling back to std::unordered_map#56ayzk merged 1 commit intoszcompressor:masterfrom
std::unordered_map#56ayzk merged 1 commit intoszcompressor:masterfrom
Conversation
Collaborator
|
Thanks for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling SZ3 on 32bit systems (wasm32 in my use case) fails because of the ska_hash implementation, which expects that
size_tis 64b wide. While there have been attempts to port ska_hash to 32 bits, e.g. in skarupke/flat_hash_map#18, pulling in those changes would place the maintenance burden on SZ3.In this PR, I'm instead suggesting a simpler solution by falling back to the
std::unordered_mapimplementation on non-64bit systems, whereska::unordered_mapis not available. This immediately unlocks 32bit support with a minimal code change.