feat: remove fallback to first saved account in get-context-token#21
Merged
Conversation
BREAKING CHANGE: get-context-token now requires --user-id explicitly. The old behavior of falling back to the first saved account when --user-id was omitted has been removed. Changes: - cli.rs: user_id changed from Option<String> to String - get_context_token.rs: removed resolve_user_id call, user_id is now required - account.rs: removed resolve_user_id function - storage.rs: removed get_account_ids function - README.md: updated get-context-token example to show required --user-id - Cargo.toml: bumped version to 0.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
get-context-tokennow requires--user-idexplicitly. The old behavior of falling back to the first saved account when--user-idwas omitted has been removed.Changes
src/cli.rs:user_idchanged fromOption<String>toStringsrc/commands/get_context_token.rs: removedresolve_user_idcall;user_idis now requiredsrc/commands/account.rs: removedresolve_user_idfunctionsrc/storage.rs: removedget_account_idsfunctionREADME.md: updatedget-context-tokenexample to show required--user-idCargo.toml: bumped version to0.4.0Validation
cargo build— successcargo test— 11 passed; 0 failedcargo clippy --all-features -- -D warnings— successcargo fmt --all --check— success