fix: pin third-party actions and trust docker publisher#891
Conversation
Pin dorny/paths-filter, softprops/action-gh-release, and peter-evans/repository-dispatch to full commit SHAs for supply chain security. Add docker to TRUSTED_PUBLISHERS in audit_actions.ts so docker/* actions are accepted with tag-only pins alongside actions/*, denoland/*, and other trusted publishers.
There was a problem hiding this comment.
Code Review
Clean, well-scoped supply chain security hardening. All three commit SHAs verified against their respective tags via the GitHub API:
dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36→ v3 ✓softprops/action-gh-release@153bb8e04406b158c6c84fc1615b65b24149a1fe→ v2 ✓peter-evans/repository-dispatch@ff45666b9427631e3450c54a1bcbee4d9ff4d7c0→ v3 ✓
Blocking Issues
None.
Suggestions
None — this is minimal and correct. The docker entry is properly alphabetized in TRUSTED_PUBLISHERS, and the SHA pins include the version tag as a trailing comment for readability.
There was a problem hiding this comment.
CI Security Review
Critical / High
None.
Medium
release.yml— Docker actions still tag-pinned: Thedocker/setup-qemu-action@v3,docker/setup-buildx-action@v3,docker/login-action@v3, anddocker/build-push-action@v6actions in thedockerjob remain pinned by tag only. This PR addsdockerto the trusted publishers list (which is a reasonable policy decision given Docker's status as a major publisher), but for maximum supply chain security these could also be SHA-pinned like the other third-party actions in this PR. Not blocking since the trust policy is an explicit, documented decision.
Low
None.
Verdict
PASS — This PR is a pure security improvement. It pins three previously tag-only third-party actions (dorny/paths-filter, softprops/action-gh-release, peter-evans/repository-dispatch) to full commit SHAs, hardening the CI/CD pipeline against supply chain attacks. Adding docker to trusted publishers is a reasonable policy choice consistent with how actions/* and denoland/* are already treated.
Summary
dorny/paths-filter,softprops/action-gh-release, andpeter-evans/repository-dispatchto full commit SHAs for supply chain securitydockertoTRUSTED_PUBLISHERSinscripts/audit_actions.tssodocker/*actions are accepted with tag-only pinsTest Plan
deno fmt --check,deno lint, anddeno run testall pass