This repository was archived by the owner on Feb 6, 2026. It is now read-only.
fix: re-anble onfailure marker for luminork tests#7684
Merged
johnrwatson merged 2 commits intomainfrom Nov 4, 2025
Merged
Conversation
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
nickgerace
previously approved these changes
Nov 4, 2025
nickgerace
reviewed
Nov 4, 2025
| } else { | ||
| break; // Exit on unexpected status codes | ||
| } | ||
| } while (getVariantResponse.status === 202 && attempts < maxAttempts); |
Contributor
There was a problem hiding this comment.
Huh, TIL about this syntax with do and while combined.
nickgerace
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enabling as the flake comment is no longer relevant
Also add a max of 5s to resolve the schema details in the failing test.
See test here for new output https://github.com/systeminit/si/actions/runs/19080282395/job/54506753708
ref: