Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions scripts/run-ui-replay.py
Original file line number Diff line number Diff line change
Expand Up @@ -1365,9 +1365,7 @@ def run_replay(args):
# rather than a silent no-op (cubic-flagged).
if args.input_backend == "xdotool":
if target_window_id is None:
raise ReplayError(
"focus-at requires a prior wait-window"
)
raise ReplayError("focus-at requires a prior wait-window")
xdotool(env, "windowfocus", target_window_id)
elif command == "resize":
if len(parts) != 3:
Expand Down
14 changes: 10 additions & 4 deletions tests/ui/replays/violawww-scroll-system.replay
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,16 @@ assert-image initial common-visible.json
motion 360 540
wheel down 5
# Wait long enough for libx11-compat's internal event loop to drain the
# wheel-down sequence and for vw to apply the scroll. The previous
# 1 second budget passed roughly four runs out of five but flaked when
# the runner was under load; this matches the resize delay below.
delay 3000
# wheel-down sequence and for vw to apply the scroll. The previous 3
# second budget still flaked on heavily loaded GitHub runners
# (changed_ratio 0.00000 on the differential job, recoverable by a
# plain rerun), so match the 6 second budget that the smoke replay
# tests/ui/replays/violawww-scroll.replay uses under
# --in-process-snapshots. wait-converge is not a drop-in replacement:
# the xdotool fallback ignores its arguments and sleeps 500 ms, and
# the in-process detector can converge on pre-input idle before vw has
# produced any Expose/Present activity.
delay 6000
screenshot scrolled
assert-image scrolled common-visible.json
assert-image scrolled violawww-scroll-changed.json
Expand Down
Loading