Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The automatic pages-build-deployment workflow (Jekyll) runs on every push to main and renders README.md as the site. It was finishing after our WASM deployment, overwriting it. The live site showed README content instead of the WebAssembly demo. Changes to deploy-pages job: - Wait for the automatic Jekyll build to complete before deploying, polling by commit SHA to target only the run from this push - Add .nojekyll to the deployed artifact to suppress Jekyll processing - Add actions:read permission required by gh run list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The automatic pages-build-deployment workflow (Jekyll) runs on every push to main and renders README.md as the site. It was finishing after our WASM deployment, overwriting it. The live site showed README content instead of the WebAssembly demo.
Changes to deploy-pages job:
Summary by cubic
Fixes a race where GitHub’s automatic Jekyll build overwrote our WASM site on deploy. The WebAssembly demo now persists after pushes to main.
Bug Fixes
Dependencies
Written for commit 570347b. Summary will update on new commits.