-
Notifications
You must be signed in to change notification settings - Fork 7
Add OCI image support: pull, unpack, run, prune, status, policy #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Max042004
wants to merge
4
commits into
sysprog21:main
Choose a base branch
from
Max042004:oci-image
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,12 @@ | ||
| build/ | ||
| archive/ | ||
| externals/ | ||
| # externals/ holds downloaded fixtures (kernel, rootfs, packages) that are | ||
| # fetched on demand; tracking them in git would balloon the repo. The | ||
| # vendored cJSON and zstd trees are exceptions: they ship with the source | ||
| # so the OCI parser and layer unpacker build out of the box. | ||
| externals/* | ||
| !externals/cjson/ | ||
| !externals/zstd/ | ||
| lib/modules/ | ||
| *.o | ||
| *.bin |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| Copyright (c) 2009-2017 Dave Gamble and cJSON contributors | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in | ||
| all copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| THE SOFTWARE. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Vendored cJSON | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: Incorrect release date for cJSON v1.7.18. The upstream release date is 2024-05-13, not 2024-07-30. This is a documentation inaccuracy. Prompt for AI agents |
||
|
|
||
| This directory contains a vendored copy of [cJSON](https://github.com/DaveGamble/cJSON), | ||
| the ultralightweight JSON parser written in ANSI C. cJSON ships as a single | ||
| `.c` / `.h` pair and is dual-licensed under the MIT license (see `LICENSE`). | ||
|
|
||
| ## Why vendored | ||
|
|
||
| `oci-roadmap.md` Q9 commits Phase 1 to hand-rolled C alongside the existing | ||
| elfuse codebase: no Go, no Rust, no `cargo` / `go` in the build matrix. cJSON | ||
| is the smallest credible JSON dependency that fits that contract; it is | ||
| self-contained, has no external dependencies, and compiles cleanly with | ||
| `clang` and `gcc` on macOS and Linux. | ||
|
|
||
| ## Version | ||
|
|
||
| Pinned to upstream tag `v1.7.18` (2024-07-30). Fetched with: | ||
|
|
||
| ``` | ||
| curl -fsSL -o cJSON.h https://raw.githubusercontent.com/DaveGamble/cJSON/v1.7.18/cJSON.h | ||
| curl -fsSL -o cJSON.c https://raw.githubusercontent.com/DaveGamble/cJSON/v1.7.18/cJSON.c | ||
| curl -fsSL -o LICENSE https://raw.githubusercontent.com/DaveGamble/cJSON/v1.7.18/LICENSE | ||
| ``` | ||
|
|
||
| ## Local modifications | ||
|
|
||
| None. The files are byte-identical to the upstream tag so future security | ||
| updates can be applied by re-running the curl commands above. | ||
|
|
||
| ## Build integration | ||
|
|
||
| The Makefile compiles `cJSON.c` with project warning flags relaxed: cJSON is | ||
| third-party code and its style does not match elfuse's `-Wpedantic | ||
| -Wmissing-prototypes -Wshadow` posture. Only `src/oci/` translation units | ||
| include `externals/cjson/cJSON.h`; the rest of the codebase never sees it. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Contradictory documentation for
--user. The options table describes it as 'numeric only', but the User and WorkingDir section immediately below describes detailed symbolic-name resolution (accepting symbolicname,name:group, reading /etc/passwd and /etc/group). These cannot both be correct.Prompt for AI agents