Fix R CMD check notes and add joint Wald pre-trends testing#139
Open
Y-C-Jiao wants to merge 2 commits into
Open
Fix R CMD check notes and add joint Wald pre-trends testing#139Y-C-Jiao wants to merge 2 commits into
Y-C-Jiao wants to merge 2 commits into
Conversation
Y-C-Jiao
commented
Apr 5, 2026
Y-C-Jiao
commented
- Declare imports properly via @importFrom tags
- Move ggplot2 to Imports in DESCRIPTION
- Update RoxygenNote to match installed version
- Replace class() == with inherits()
- Add calculate_wald_pre_test() for joint chi-squared pre-trends test
- Add synthdid_wald_test() for general joint Wald test
- Add print.synthdid_wald_test() display method
- Add vignette documenting full workflow and both test functions
- Declare imports properly via @importFrom tags - Move ggplot2 to Imports in DESCRIPTION - Update RoxygenNote to match installed version - Replace class() == with inherits() - Add calculate_wald_pre_test() for joint chi-squared pre-trends test - Add synthdid_wald_test() for general joint Wald test - Add print.synthdid_wald_test() display method - Add vignette documenting full workflow and both test functions
Author
|
The Lost braces NOTE is now fixed. The remaining ERROR (CVXR::solve), WARNING, and License NOTE are pre-existing issues in the original repository unrelated to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.