fix: add LocalizedError for readable error messages #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Custom error enums (CustomServiceError, KeychainError) now conform to LocalizedError and provide human-readable errorDescription. Previously, these errors displayed as "The operation couldn't be completed. (Bitkit.CustomServiceError error 1.)" which was not helpful to users.
ben-kaufman
force-pushed
the
fix/localized-error-descriptions
branch
from
7dff720 to
df1c0d3
Compare
CancellationError is thrown when tasks are cancelled (e.g., user navigates away during sync). This is expected behavior and shouldn't show an error toast to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes error toasts that previously showed unhelpful messages like "The operation couldn't be completed. (Bitkit.CustomServiceError error 1.)".
Custom error enums now conform to
LocalizedErrorand provide human-readable error descriptions that are displayed to users.Linked Issues/Tasks
N/A
Screenshot / Video
Before:
After:
