feat(send): node connecting UI #401
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwltr
force-pushed
the
feat/node-connecting-ui
branch
from
08d95b0 to
9555fd1
Compare
This comment has been minimized.
This comment has been minimized.
ben-kaufman
reviewed
Jan 26, 2026
Comment on lines
+217
to
+221
| // DEBUG: Add artificial delay to test sync overlay UI | ||
| #if DEBUG | ||
| try? await Task.sleep(nanoseconds: 10_000_000_000) // 5 seconds | ||
| #endif | ||
|
|
Contributor
There was a problem hiding this comment.
Do we still want to leave this?
This reverts commit 0500361.
This comment has been minimized.
This comment has been minimized.
ben-kaufman
reviewed
Jan 26, 2026
| /// Validates payment affordability after sync completes | ||
| /// For lightning: falls back to onchain for unified invoices, shows error for pure lightning invoices | ||
| /// For onchain: validates balance and shows error if insufficient | ||
| private func validatePaymentAfterSync() { |
Contributor
There was a problem hiding this comment.
The insufficient amount toast only shows up now if opening before sync, but scanning after node is synced doesn't give the toast. Also after the toast for LN user can still click continue and try the payment (which then fails), it should be disabled like in onchain
Collaborator
|
There seems to be a regression (from e2e
Screen.Recording.2026-01-26.at.20.59.54.mov |
Member
|
Waiting for the fixes to do a review... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues/Tasks
Closes #339
Screenshot / Video
Unified invoice:
Simulator.Screen.Recording.-.iPhone.17.-.2026-01-16.at.01.00.09.mov
QuickPay (deeplink):
Simulator.Screen.Recording.-.iPhone.17.-.2026-01-16.at.01.00.09.mov
QA Notes
Use a deeplink like