Add OMIT_IMPORT_ID environment variable#431
Open
deanlongstaff wants to merge 1 commit intosyncforynab:mainfrom
Open
Add OMIT_IMPORT_ID environment variable#431deanlongstaff wants to merge 1 commit intosyncforynab:mainfrom
OMIT_IMPORT_ID environment variable#431deanlongstaff wants to merge 1 commit intosyncforynab:mainfrom
Conversation
Add support for a new `OMIT_IMPORT_ID` environment variable to allow webhook transactions to be treated as user-entered rather than imported transactions. When OMIT_IMPORT_ID is set: - Monzo and Starling webhook controllers pass omit_import_id: true to webhook classes - Starlingv2 controller passes nil as import_id to TransactionCreator - Transactions become eligible for matching against future imports via Direct Import or other means This enables transaction deduplication by allowing webhook transactions to be matched with later Direct Import/File Based Import transactions that have the same amount and date (±10 days). Updated controllers: - MonzoController: Added omit_import_id parameter - StarlingController: Added omit_import_id parameter - Starlingv2Controller: Added conditional import_id logic
Author
|
This PR is dependent on a seperate PR in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for a new
OMIT_IMPORT_IDenvironment variable to allow webhook transactions to be treated as user-entered rather than imported transactions.When
OMIT_IMPORT_IDis set totrue:omit_import_id: trueto webhook classesThis enables transaction deduplication by allowing webhook transactions to be matched with later Direct Import/File Based Import transactions that have the same amount and date (±10 days).
Updated controllers:
omit_import_idparameteromit_import_idparameterimport_idlogic