This repository was archived by the owner on Mar 10, 2025. It is now read-only.
Add a page to handle OAuth redirection #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a page to the syncany.org web server that can be used to receive a redirect when https is required or local host is not allowed. It then redirects to the Syncany application at localhost.
This is needed to get the Hubic plugin to work. Hubic requires the redirect URL to be HTTPS. It would have been possible to setup up SSL socket listener in the Syncany application. However the certificate would have to be self-signing (all Certificate Authorities want one to prove rights to a domain name etc), and if a self-signed certificate is used then browsers give security warnings to the users which we don't really want. So in the end I think this is the best approach. This approach also involved minimal changes to the code in the oauth package in Syncany.
I am confident this will work as I have tested it on another HTTPS server, and just edited the URLs in the browser. If you can get this onto the syncany.org server then this will help with the testing of the rest of the changes.