Fix syntax errors/warnings in 6.4 #21614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
wouterj
commented
Nov 29, 2025
| in the development branch. | ||
| * **Bug**: Only for bug fixes; We are very conservative when it comes to | ||
| merging older, but still maintained, branches. Read the :doc:`maintenance` | ||
| merging older, but still maintained, branches. Read the :doc:`/contributing/code/maintenance` |
Member
Author
There was a problem hiding this comment.
@OskarStark this might be an interesting one for DOCtor when you have time: we want all doc references to be absolute paths, so the links don't break when moving documents/sections. This has been a rule since forever, but every once in a while one relative path slips in :)
Contributor
There was a problem hiding this comment.
OK, I created an issue for DOCtor
OskarStark
approved these changes
Nov 29, 2025
Contributor
|
Thank you @wouterj. |
OskarStark
added a commit
that referenced
this pull request
Nov 29, 2025
This was referenced Dec 9, 2025
OskarStark
added a commit
that referenced
this pull request
Dec 10, 2025
…path` rule (OskarStark) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- Update DOCtor-RST to 1.77.0 and enable `no_relative_doc_path` rule - Require DOCtor-RST 1.77.0 - Enable `no_relative_doc_path` rule to ensure `:doc:` directives use absolute paths ### Refs * #21614 (comment) `@wouterj` * OskarStark/doctor-rst#2180 * OskarStark/doctor-rst#2213 I will take care of the upmerge and fixing the other issues in the upper branches, once approved. Commits ------- 67506ba Update DOCtor-RST to 1.77.0 and enable `no_relative_doc_path` rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some syntax warnings found by the phpDocument parser that were introduced in the past year.
I'll see if I can maybe add a new CI job with the new parser, which is a lot more detailed about syntax mistakes. That'll help us prepare for the migration.