[Validator] Add docs for number constraints #11254
Conversation
jschaedl
force-pushed
the
validator-number_constraints
branch
2 times, most recently
from
24d8f34 to
0fd69b6
Compare
OskarStark
left a comment
OskarStark
left a comment
There was a problem hiding this comment.
Thank you 👍🏻
I left some comments.
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Work
labels
jschaedl
force-pushed
the
validator-number_constraints
branch
from
dbd9096 to
c5007ae
Compare
* Positive constraint * PositiveOrZero constraint * Negative constraint * NegativeOrZero constraint
jschaedl
force-pushed
the
validator-number_constraints
branch
from
b4ca4a2 to
6155df4
Compare
|
Please include your new constraints in reference/constraints.rst, otherwise Sphinx won't be able to build the docs. |
| Parameter Description | ||
| ============================= ================================================ | ||
| ``{{ compared_value }}`` Always zero | ||
| ``{{ compared_value_type }}`` The expected value type |
There was a problem hiding this comment.
Not sure if we should include compared_value and compared_value_type here. They are available, but it doesn't make so much sense to me to use them. WDYT?
There was a problem hiding this comment.
I am not sure if we haven't added such (if available) parameters for other constraints.
Please help @xabbuh @javiereguiluz
There was a problem hiding this comment.
Even if they won't be used frequently, for consistency with the other constraints I'd prefer to keep them. We always try to document all parameters. Thanks.
OskarStark
left a comment
OskarStark
left a comment
There was a problem hiding this comment.
Great work, thank you! 👍
|
@jschaedl thanks a lot for providing these docs (and the related feature too). Congrats on your first (great) Symfony Docs contribution! |
4 participants
Feature PR: symfony/symfony#28637
Todo:
NegativeOrZeroconstraint