MutableAclProvider is now compatible with doctrine/persistence 4.x#131
Open
Cosmologist wants to merge 1 commit into
Open
MutableAclProvider is now compatible with doctrine/persistence 4.x#131Cosmologist wants to merge 1 commit into
Cosmologist wants to merge 1 commit into
Conversation
This change is safe for backward compatibility.
Member
It is not. You'll break downstream projects that override this very method. |
Author
What I meant was that the edit would not affect the functionality of the code for the range of PHP and Doctrine versions specified in composer.json. |
|
See #123 which already proposed this change but it does indeed break BC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is safe for backward compatibility.