Skip to content

Fix PHP 8.4 implicitly nullable deprecation#124

Merged
wouterj merged 1 commit into
symfony:mainfrom
acrobat:fix-php84-deprecation
Feb 14, 2025
Merged

Fix PHP 8.4 implicitly nullable deprecation#124
wouterj merged 1 commit into
symfony:mainfrom
acrobat:fix-php84-deprecation

Conversation

@acrobat

@acrobat acrobat commented Feb 9, 2025

Copy link
Copy Markdown
Contributor

Fix the Implicitly marking parameter XXX as nullable is deprecated, the explicit nullable type must be used instead deprecation in PHP 8.4

This PR also enables to CI build against php 8.3 and 8.4

@wouterj

wouterj commented Feb 14, 2025

Copy link
Copy Markdown
Member

Thanks @acrobat!

@wouterj wouterj merged commit fcaca8b into symfony:main Feb 14, 2025
@acrobat acrobat deleted the fix-php84-deprecation branch February 14, 2025 13:43
@dannyvw

dannyvw commented May 14, 2025

Copy link
Copy Markdown

@wouterj Is it possible to create a new release with this fixes?

@wouterj

wouterj commented May 16, 2025

Copy link
Copy Markdown
Member

Given this is only a deprecation notice, so nothing breaking, I prefer to wait a bit for a more significant change. Otherwise, we're burning network resources from everyone updating for no benefit :)

Let's see if work is needed for Symfony 7.3 compatibility or maybe finish #123

@a24710

a24710 commented Jul 10, 2025

Copy link
Copy Markdown

+1 to a new release for this please. We are upgrading to php 8.4 and we would like to keep the warnings as close to zero as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants