Fix PHP 8.4 implicitly nullable deprecation#124
Merged
Conversation
OskarStark
approved these changes
Feb 9, 2025
nicolas-grekas
approved these changes
Feb 10, 2025
derrabus
approved these changes
Feb 11, 2025
xabbuh
approved these changes
Feb 11, 2025
Member
|
Thanks @acrobat! |
|
@wouterj Is it possible to create a new release with this fixes? |
Member
|
Given this is only a deprecation notice, so nothing breaking, I prefer to wait a bit for a more significant change. Otherwise, we're burning network resources from everyone updating for no benefit :) Let's see if work is needed for Symfony 7.3 compatibility or maybe finish #123 |
|
+1 to a new release for this please. We are upgrading to php 8.4 and we would like to keep the warnings as close to zero as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
Implicitly marking parameter XXX as nullable is deprecated, the explicit nullable type must be used insteaddeprecation in PHP 8.4This PR also enables to CI build against php 8.3 and 8.4