-
-
Notifications
You must be signed in to change notification settings - Fork 137
[Agent][Platform][OpenAI] Add stream usage support #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oesteve
wants to merge
16
commits into
symfony:main
Choose a base branch
from
oesteve:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12669c7 to
e0ad357
Compare
OskarStark
reviewed
Nov 29, 2025
Comment on lines
51
to
52
| // Chunk also contain metadata | ||
| // $textChunk->getMetadata()->get('id'); // Stream id |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
OskarStark
reviewed
Nov 29, 2025
| /** @var TextChunk $textChunk */ | ||
| foreach ($result->getContent() as $textChunk) { | ||
|
|
||
| // $textChunk implement \Stringable |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
bcbc538 to
1535511
Compare
OskarStark
reviewed
Nov 29, 2025
OskarStark
reviewed
Nov 29, 2025
| ], | ||
| ]); | ||
|
|
||
| // Output text chunks |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| // Output text chunks |
OskarStark
reviewed
Nov 29, 2025
OskarStark
reviewed
Nov 29, 2025
…ing results integration
…ring content type
… replace `StreamChunk` with `TextChunk`
- Remove irrelevant comments. - Enhance readability. - Eliminate unused instantiations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Agent
Issues & PRs about the AI Agent component
Feature
New feature
Platform
Issues & PRs about the AI Platform component
Status: Needs Review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.