oci: support for SCIF, incl. --app#2348
Merged
preminger merged 7 commits intosylabs:mainfrom Nov 14, 2023
Merged
Conversation
preminger
changed the title
preminger
force-pushed
the
1470-support-app-in-oci-mode-scif-in-oci
branch
6 times, most recently
from
c4299ad to
6323604
Compare
preminger
changed the title
dtrudg
requested changes
Nov 14, 2023
Member
dtrudg
left a comment
dtrudg
left a comment
There was a problem hiding this comment.
A couple of comments left.
More generally, I don't think that having inspect --oci dump out SCIF specific output is right.
- I think
inspect --oci --app xxxoutput is fine to show SCIF app xxxx - I think that
inspect --oci --list-appsshowing all SCIF apps would be fine. - I think that a general
inspect --ocishould show OCI config for any OCI-SIF image... but that is outside of the scope here.
It's probably best to pull out the inspect stuff here, and then...
- Implement the general OCI-SIF inspect.
- Add the SCIF specific piece.
preminger
force-pushed
the
1470-support-app-in-oci-mode-scif-in-oci
branch
from
2224ee5 to
920c8a9
Compare
preminger
force-pushed
the
1470-support-app-in-oci-mode-scif-in-oci
branch
from
920c8a9 to
cd9d098
Compare
Contributor
Author
|
Tentative implementation of |
dtrudg
approved these changes
Nov 14, 2023
Contributor
|
Just saw this in my Twitter DMs - sorry I missed the earlier discussion. Super cool and nice job @preminger ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Adds support for SCIF apps in OCI-mode using
--appcommand-line option.NOTE: This feature assumes a Docker-style SCIF container built with the
scifexecutable as CMD or ENTRYPOINT, as per the instructions in the SCIF tutorial (archived here).This fixes or addresses the following GitHub issues:
--appin--ocimode (SCIF in OCI) #1470